[Asterisk-code-review] app_mp3: Document and warn about HTTPS incompatibility. (asterisk[master])

N A asteriskteam at digium.com
Sat Feb 5 15:27:45 CST 2022


Attention is currently required from: N A.
Hello Sean Bright, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/18002

to look at the new patch set (#2).

Change subject: app_mp3: Document and warn about HTTPS incompatibility.
......................................................................

app_mp3: Document and warn about HTTPS incompatibility.

mpg123 doesn't support HTTPS, but the MP3Player application
doesn't document this or warn the user about this. HTTPS
streams have become more common nowadays and users could
reasonably try to play them without being aware they should
use the HTTP stream instead.

This adds documentation to note this limitation. It also
throws a warning if users try to use the HTTPS stream to
tell them to use the HTTP stream instead.

ASTERISK-29900 #close

Change-Id: Ie3b029be5258c5a701f71ed3b1a7a80d1e03b827
---
M apps/app_mp3.c
1 file changed, 5 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/02/18002/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18002
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie3b029be5258c5a701f71ed3b1a7a80d1e03b827
Gerrit-Change-Number: 18002
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220205/0f37dd5e/attachment.html>


More information about the asterisk-code-review mailing list