[Asterisk-code-review] taskprocessor.c: Prevent crash on graceful shutdown (asterisk[16])

[Benjamin Keith Ford]

Attention is currently required from: Michael Bradeen, Joshua Colp.
Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17955 )

Change subject: taskprocessor.c: Prevent crash on graceful shutdown
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File main/taskprocessor.c:

https://gerrit.asterisk.org/c/asterisk/+/17955/comment/d0659109_fb040086 
PS3, Line 293: 	int objcount, tries;
Very minor, so feel free to ignore, but I would put these on 2 separate lines in case something needs to be changed later.


https://gerrit.asterisk.org/c/asterisk/+/17955/comment/d260d86a_fe41bd7c 
PS3, Line 307: 		/* give the running taskprocessors a chance to finish, up to 5 seconds */
In taskprocessor.h, you've got 10 instead of 5. Maybe change to "up to AST_TASKPROCESOR_SHUTDOWN_MAX_WAIT seconds"



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17955
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia932fc003d316389b9c4fd15ad6594458c9727f1
Gerrit-Change-Number: 17955
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Fri, 04 Feb 2022 14:29:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220204/05528333/attachment-0001.html>