[Asterisk-code-review] taskprocessor.c: Prevent crash on graceful shutdown (asterisk[16])

[Michael Bradeen]

Attention is currently required from: Joshua Colp.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17955 )

Change subject: taskprocessor.c: Prevent crash on graceful shutdown
......................................................................


Patch Set 2:

(4 comments)

File main/taskprocessor.c:

https://gerrit.asterisk.org/c/asterisk/+/17955/comment/7837da6b_9e868513 
PS1, Line 293: 	struct timespec delay = {1,0};
> Add a comment explaining the situation with this in more detail
Done


https://gerrit.asterisk.org/c/asterisk/+/17955/comment/93d8d0c7_33eb023e 
PS1, Line 294: 	int objcount, tries=0;
> code formatting, goes for other places too
Done


https://gerrit.asterisk.org/c/asterisk/+/17955/comment/2bf050ce_c9ef98c9 
PS1, Line 298: 		ast_log(LOG_WARNING,
> I think this should be debug, it's not really meaningful to users
Done


https://gerrit.asterisk.org/c/asterisk/+/17955/comment/2455fb4c_04eb581a 
PS1, Line 303: 	while(objcount > 0 && tries < 10){
> Could this be a for loop instead?
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17955
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia932fc003d316389b9c4fd15ad6594458c9727f1
Gerrit-Change-Number: 17955
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Thu, 03 Feb 2022 19:28:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220203/7dfb3046/attachment.html>