[Asterisk-code-review] taskprocessor.c: Prevent crash on graceful shutdown (asterisk[16])

[Joshua Colp]

Attention is currently required from: Michael Bradeen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17955 )

Change subject: taskprocessor.c: Prevent crash on graceful shutdown
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

File main/taskprocessor.c:

https://gerrit.asterisk.org/c/asterisk/+/17955/comment/600b401f_ea3bb3ac 
PS1, Line 293: 	struct timespec delay = {1,0};
Add a comment explaining the situation with this in more detail


https://gerrit.asterisk.org/c/asterisk/+/17955/comment/ec8f6965_da2e1e55 
PS1, Line 294: 	int objcount, tries=0;
code formatting, goes for other places too


https://gerrit.asterisk.org/c/asterisk/+/17955/comment/40b8f21f_25eb3ce8 
PS1, Line 298: 		ast_log(LOG_WARNING,
I think this should be debug, it's not really meaningful to users


https://gerrit.asterisk.org/c/asterisk/+/17955/comment/020d36f3_64056f6b 
PS1, Line 303: 	while(objcount > 0 && tries < 10){
Could this be a for loop instead?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17955
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia932fc003d316389b9c4fd15ad6594458c9727f1
Gerrit-Change-Number: 17955
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Thu, 03 Feb 2022 11:45:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220203/58a825fe/attachment.html>