[Asterisk-code-review] cli: Add core dump info to core show settings. (asterisk[master])

N A asteriskteam at digium.com
Wed Feb 2 12:32:54 CST 2022


Attention is currently required from: Sean Bright, Joshua Colp, George Joseph.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17868 )

Change subject: cli: Add core dump info to core show settings.
......................................................................


Patch Set 7:

(1 comment)

File main/asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/17868/comment/471d7487_e4b28113 
PS6, Line 3901: #ifndef eaccess
> Was this added because you don't #undef above? If so, wouldn't eaccess always be available now?
I guess so, since it's not undef'ed, but the original code was not undef'ing it.

I guess I can just remove this whole macro block down here (starting from the 2nd #if) altogether? Seems like it's ~ #if 0 at this point.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17868
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic42c0a9ecc233381aad274d86c62808d1ebb4d83
Gerrit-Change-Number: 17868
Gerrit-PatchSet: 7
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-CC: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 18:32:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220202/72828665/attachment.html>


More information about the asterisk-code-review mailing list