[Asterisk-code-review] app_if: Adds conditional branch applications (asterisk[master])

N A asteriskteam at digium.com
Wed Feb 2 11:58:46 CST 2022


Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16121 )

Change subject: app_if: Adds conditional branch applications
......................................................................


Patch Set 5:

(1 comment)

File apps/app_if.c:

https://gerrit.asterisk.org/c/asterisk/+/16121/comment/527ce13c_b4b43a99 
PS5, Line 265: 		pbx_builtin_setvar_helper(chan, my_name, label);
> I'm not sure how increasing performance factors in to this. […]
I understand.
OT to this issue, but considering most users don't use or want Newexten and Varset, any thought on a change to disable those by default - perhaps as master-only?
The few people who actually need/want them can easily re-enable them, and then the rest don't need to deal with all that noise.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16121
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3aa3bd35a5add82465c6ee9bd86b64601f0e1f49
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 17:58:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220202/ca0d3aed/attachment.html>


More information about the asterisk-code-review mailing list