[Asterisk-code-review] app_if: Adds conditional branch applications (asterisk[master])

Joshua Colp asteriskteam at digium.com
Wed Feb 2 11:47:59 CST 2022


Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16121 )

Change subject: app_if: Adds conditional branch applications
......................................................................


Patch Set 5:

(1 comment)

File apps/app_if.c:

https://gerrit.asterisk.org/c/asterisk/+/16121/comment/dec52367_4b7e4ae7 
PS5, Line 265: 		pbx_builtin_setvar_helper(chan, my_name, label);
> None on my system ;) […]
Your system is not equivalent to the user base.

No, I'm just trying to understand the impact of this and thus knowing how many events actual usage of this causes is good information to have.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16121
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3aa3bd35a5add82465c6ee9bd86b64601f0e1f49
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 17:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220202/17761bd2/attachment.html>


More information about the asterisk-code-review mailing list