[Asterisk-code-review] app_if: Adds conditional branch applications (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/16121 )

Change subject: app_if: Adds conditional branch applications
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

File apps/app_if.c:

https://gerrit.asterisk.org/c/asterisk/+/16121/comment/10565b54_ae48a199 
PS5, Line 136: static const char *get_index(struct ast_channel *chan, const char *prefix, int idx) {
{ should be on the next line


https://gerrit.asterisk.org/c/asterisk/+/16121/comment/ab02e1ae_b31971c3 
PS5, Line 149: 	for (e=ast_walk_context_extensions(c, NULL); e; e=ast_walk_context_extensions(c, e)) {
This should be updated to current standards to include spaces around =, same applies for other things


https://gerrit.asterisk.org/c/asterisk/+/16121/comment/7a5060ca_16782c16 
PS5, Line 265: 		pbx_builtin_setvar_helper(chan, my_name, label);
How many AMI events and stasis messages does the use of setvar_helper in here result in?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/16121
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I3aa3bd35a5add82465c6ee9bd86b64601f0e1f49
Gerrit-Change-Number: 16121
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Wed, 02 Feb 2022 17:42:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220202/2a005922/attachment.html>