[Asterisk-code-review] ami: Allow events to be globally disabled. (asterisk[master])

N A asteriskteam at digium.com
Wed Feb 2 11:18:26 CST 2022


Attention is currently required from: Joshua Colp, Mark Murawski.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17793 )

Change subject: ami: Allow events to be globally disabled.
......................................................................


Patch Set 5:

(1 comment)

File configs/samples/manager.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/17793/comment/d85c4a98_50559be3 
PS3, Line 85: ; frequent events which are not desired, this can boost performance. Default
> Have you observed this boosting performance or is this just an assumption?
Yes, it boosts performance, just from looking at the code... but I think what you're getting at is how substantial it is, and that I cannot answer as there is no real good way to do so.
I've removed this verbiage just to avoid any gray areas here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17793
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Id42b9a3722a1f460d745cad1ebc47c537fd4f205
Gerrit-Change-Number: 17793
Gerrit-PatchSet: 5
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-CC: Mark Murawski <markm at intellasoft.net>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Wed, 02 Feb 2022 17:18:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220202/10276890/attachment.html>


More information about the asterisk-code-review mailing list