[Asterisk-code-review] build_tools/make_version: Fix bashism in comparison. (asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue Feb 1 14:31:33 CST 2022


Joshua Colp has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/17953 )

Change subject: build_tools/make_version: Fix bashism in comparison.
......................................................................

build_tools/make_version: Fix bashism in comparison.

In POSIX sh (which we indicate in the shebang), there is no ==
operator.

Change-Id: Ic03d38214d14cdf329b0ba272279a815bb532965
---
M build_tools/make_version
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve; Approved for Submit
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Michael Bradeen: Looks good to me, but someone else must approve



diff --git a/build_tools/make_version b/build_tools/make_version
index 6ef7b29..aefe6b1 100755
--- a/build_tools/make_version
+++ b/build_tools/make_version
@@ -101,7 +101,7 @@
     SVN_REV=`${GIT} log --pretty=full -1 | sed -n '/git-svn-id:/ s/.*\@\([^ ]*\) .*/\1/p'`
     if [ -z "$SVN_REV" ]; then
         MAINLINE_BRANCH=$(${GIT} config -f .gitreview --get gerrit.basebranch)
-        if [ "x${MAINLINE_BRANCH}" == "x" ] ; then
+        if [ "x${MAINLINE_BRANCH}" = "x" ] ; then
             MAINLINE_BRANCH=$(${GIT} config -f .gitreview --get gerrit.defaultbranch)
         fi
 

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic03d38214d14cdf329b0ba272279a815bb532965
Gerrit-Change-Number: 17953
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220201/4d21b5c7/attachment-0001.html>


More information about the asterisk-code-review mailing list