[Asterisk-code-review] app_mf: Add max digits option to ReceiveMF (asterisk[master])

[Sean Bright]

Attention is currently required from: N A.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17941 )

Change subject: app_mf: Add max digits option to ReceiveMF
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/17941/comment/f3de10d8_15839343 
PS2, Line 7: app_mf: Add max digits option to ReceiveMF
There _should_ be a period at the end of this line according to commit guidelines, but we're not consistent, so take it or leave it.


https://gerrit.asterisk.org/c/asterisk/+/17941/comment/4c7babb0_084765c1 
PS2, Line 9: Adds an option to the ReceiveMF application
           : to allow specifying a maximum number of digits.
           : 
           : Originally, this capability was not added
           : to ReceiveMF as it was with ReceiveSF because
           : typically a ST digit is used to denote that
           : sending of digits is complete. However, there
           : are certain signaling protocols which simply
           : transmit a digit (such as Expanded In-Band
           : Signaling) and for these, it's necessary to
           : be able to read a certain number of digits,
           : as opposed to until receiving a ST digit.
           : 
           : This capability is added as an option, as
           : opposed to as a parameter, to remain
           : compatible with existing usage (and not
           : shift the parameters).
This is super tight wrapping. Shoot for 72 columns. The 'fold' command can help with this (Something like: `fold -w 72 -s commit-msg.txt` but don't quote me on that.)



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17941
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4229167c9aa69b87402c3c2a9065bd8dfa973a0b
Gerrit-Change-Number: 17941
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 18:01:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220201/0cc0ae82/attachment.html>