[Asterisk-code-review] manager.c: Generate valid XML if attribute names have leading digits. (asterisk[16])
Sean Bright
asteriskteam at digium.com
Tue Feb 1 10:04:01 CST 2022
Attention is currently required from: Kevin Harwell.
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17947 )
Change subject: manager.c: Generate valid XML if attribute names have leading digits.
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://gerrit.asterisk.org/c/asterisk/+/17947/comment/5416fa5b_32b482a3
PS1, Line 12: This is not backwards compatible but my assumption is that compliant
: XML parsers would already have been complaining about this.
> I agree, but I think a blurb in UPGRADE.txt would be good just in case.
Ack
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17947
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Icfaa56a131a082d803e9b7db5093806d455a0523
Gerrit-Change-Number: 17947
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Bright <sean at seanbright.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Attention: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 01 Feb 2022 16:04:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220201/ea952876/attachment.html>
More information about the asterisk-code-review
mailing list