[Asterisk-code-review] res_http_media_cache: Introduce options and customize (asterisk[20])

[Holger Hans Peter Freyther]

Attention is currently required from: Sean Bright, Joshua Colp.

Holger Hans Peter Freyther has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Introduce options and customize
......................................................................


Patch Set 6:

(1 comment)

File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/0f8032f5_d9534e77 
PS5, Line 734: #ifdef AST_CURL_HAS_PROTOCOLS_STR
> If this isn't inherently possible with config options, then falling back would be acceptable.
It seems it is not possible to load defaults when the file is missing and otherwise decline loading.

Looking at aco_process_config it returns ACO_PROCESS_ERROR on CONFIG_STATUS_FILEMISSING, CONFIG_STATUS_FILEINVALID and on the pre hooks.

The only way I could handle this is to call ast_config_load ourselves to check for file missing. Would this be a reasonable approach (the other modules don't seem to do that).



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 6
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 28 Dec 2022 12:09:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221228/69a83c00/attachment.html>