[Asterisk-code-review] res_hiredis: Redis Device State and Dialplan functions. (asterisk[master])

[Sean Bright]

Attention is currently required from: Alec Davis, N A.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18829 )

Change subject: res_hiredis: Redis Device State and Dialplan functions.
......................................................................


Patch Set 24: Code-Review-2

(1 comment)

Patchset:

PS24: 
I fixed the merge conflict and a couple odds and ends.

I still don't like that you can only have a single Redis connection defined. My opinion is that multiple connection awareness is a bare minimum for inclusion. Once this is released, that will immediately be a feature request/contribution and we will need to retrofit the dialplan API to support it which will be a nightmare. So let's just get it right the first time.

I also think this should just be called res_redis - the fact that it's using hiredis instead of another Redis library is an implementation detail and someone could add support for another Redis client library down the road and then the module name is meaningless.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifdf4d33d2a2a5fd044fac13b201c7437de34ba6a
Gerrit-Change-Number: 18829
Gerrit-PatchSet: 24
Gerrit-Owner: Alec Davis <alec at bdt.co.nz>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Alec Davis <alec at bdt.co.nz>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Tue, 27 Dec 2022 15:46:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221227/1bef90e0/attachment.html>