[Asterisk-code-review] app_macro: Remove deprecated module. (asterisk[master])

N A asteriskteam at digium.com
Fri Dec 23 12:06:30 CST 2022


Attention is currently required from: Michael Bradeen, Richard Mudgett.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19708 )

Change subject: app_macro: Remove deprecated module.
......................................................................


Patch Set 6: Code-Review+1

(1 comment)

Patchset:

PS6: 
I would prefer that configs/samples/extensions_minivm.conf.sample be updated since there are still macro things in there. Should be as simple as removing macro- from the contexts and cleaning up a few comments.

But if you don't want to do that now, then someone can do it later as a separate change. Up to you. If it's being deferred, might be good to open an issue for it so we don't forget.

Otherwise, looks good to me.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19708
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I830daab293117179b8d61bd4df0d971a1b3d07f6
Gerrit-Change-Number: 19708
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 23 Dec 2022 18:07:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221223/f71e9cfd/attachment-0001.html>


More information about the asterisk-code-review mailing list