[Asterisk-code-review] utils: Refactor ast_str CURLOPT_WRITEFUNCTION callback. (asterisk[18])

[N A]

Attention is currently required from: Sean Bright.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19736 )

Change subject: utils: Refactor ast_str CURLOPT_WRITEFUNCTION callback.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
> I would prefer not to introduce API for 1 line of code.
I respectfully disagree on this one, there are other APIs that are only a few lines as well, but they exist for a reason.

This has to be a function, so it doesn't make much sense to have modules duplicating it (especially since your comments point out that it's easy to implement the callback inefficiently). Copying and pasting this around shouldn't be the preferred way to do it.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19736
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ib804ada46b345b2281062769affb1ea5a7a4249c
Gerrit-Change-Number: 19736
Gerrit-PatchSet: 3
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 22:50:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/aeef8f84/attachment-0001.html>