[Asterisk-code-review] utils: Refactor ast_str CURLOPT_WRITEFUNCTION callback. (asterisk[master])

[Sean Bright]

Attention is currently required from: N A, Richard Mudgett.

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19718 )

Change subject: utils: Refactor ast_str CURLOPT_WRITEFUNCTION callback.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File main/utils.c:

https://gerrit.asterisk.org/c/asterisk/+/19718/comment/281d38de_d9b9baf5 
PS2, Line 2716: 
              : size_t ast_curl_write_str_callback(void *contents, size_t size, size_t nmemb, void *userdata)
              : {
              : 	struct ast_str **buffer = userdata;
              : 	size_t realsize = size * nmemb;
              : 	char *rawdata;
              : 
              : 	rawdata = ast_malloc(realsize + 1);
              : 	if (!rawdata) {
              : 		return 0;
              : 	}
              : 	memcpy(rawdata, contents, realsize);
              : 	rawdata[realsize] = 0;
              : 	ast_str_append(buffer, 0, "%s", rawdata);
              : 	ast_free(rawdata);
              : 
              : 	return realsize;
              : }
No allocation is required. This can just be (with a typecast or two as needed):

 size_t ast_curl_write_str_callback(char *buffer, size_t sz, size_t nmemb, void *userdata)
 {
     return ast_str_append(
         (struct ast_str **) userdata, 0, "%.*s", (int) (sz * nmemb), buffer);
 }



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19718
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ib804ada46b345b2281062769affb1ea5a7a4249c
Gerrit-Change-Number: 19718
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 17:19:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/7788b5d9/attachment.html>