[Asterisk-code-review] apps/app_queue: Preserve reason for realtime queues (asterisk[18])

[Niklas Larsson]

Attention is currently required from: N A, Alexei Gradinari, Stanislav Abramenkov.

Niklas Larsson has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19741 )

Change subject: apps/app_queue: Preserve reason for realtime queues
......................................................................


Patch Set 7:

(4 comments)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/3bde6ff6_b7692941 
PS6, Line 3660: ast_copy_string
> If field reason_paused doesn't exist in DB table then previous value will be lost. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/fb6bf960_c74fbcd4 
PS6, Line 7753: == 0
> The function ast_update_realtime returns number of rows affected, or -1 on error. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/6fb867aa_71cb97c2 
PS6, Line 7758: update_realtime_member_field
> The rt_uniqueid is already checked, no need to call function update_realtime_member_field. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/f282a615_67db8d53 
PS6, Line 11714: This section is used to determine which name for 'ringinuse' to use in realtime members
               : 	 * Necessary for supporting older setups.
> Need to add to comment about reason_paused
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 7
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 16:06:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/92a05193/attachment.html>