[Asterisk-code-review] apps/app_queue: Preserve reason for realtime queues (asterisk[18])

[Alexei Gradinari]

Attention is currently required from: N A, Stanislav Abramenkov, Niklas Larsson.

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19741 )

Change subject: apps/app_queue: Preserve reason for realtime queues
......................................................................


Patch Set 6: Code-Review-1

(4 comments)

File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/8ebe121f_71c2c601 
PS6, Line 3660: ast_copy_string
If field reason_paused doesn't exist in DB table then previous value will be lost.
Maybe need to check realtime_reason_paused?


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/3326dd64_e8d624d9 
PS6, Line 7753: == 0
The function ast_update_realtime returns number of rows affected, or -1 on error.
Should be < 0 to log error.


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/95f2effc_02ea5b70 
PS6, Line 7758: update_realtime_member_field
The rt_uniqueid is already checked, no need to call function update_realtime_member_field. Call ast_update_realtime.


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/2f3099d6_f256dcec 
PS6, Line 11714: This section is used to determine which name for 'ringinuse' to use in realtime members
               : 	 * Necessary for supporting older setups.
Need to add to comment about reason_paused



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 6
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Niklas Larsson <niklas at tese.se>
Gerrit-Comment-Date: Thu, 22 Dec 2022 15:19:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/945a7e91/attachment.html>