[Asterisk-code-review] chan_sip: Remove deprecated module. (asterisk[master])
N A
asteriskteam at digium.com
Thu Dec 22 08:15:13 CST 2022
Attention is currently required from: Michael Bradeen.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19611 )
Change subject: chan_sip: Remove deprecated module.
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
Patchset:
PS2:
> Sorry, a couple more stragglers: […]
This chan_sip stuff should also be removed:
contrib/scripts/autosupport: "sip show peers" "sip show registry" "sip show channels" "sip show subscriptions" "sip show settings"
Additionally, these contrib scripts are obsolete:
contrib/scripts/retrieve_sip_conf_from_mysql.pl:# Retrieves the sip user/peer entries from the database
contrib/scripts/retrieve_sip_conf_from_mysql.pl:#CREATE TABLE sip (id INT(11) DEFAULT -1 NOT NULL,keyword VARCHAR(20) NOT NULL,data VARCHAR(50) NOT NULL, flags INT(1) DEFAULT 0 NOT NULL,PRIMARY KEY (id,keyword));
contrib/scripts/retrieve_sip_conf_from_mysql.pl:$table_name = "sip";
contrib/scripts/retrieve_sip_conf_from_mysql.pl:$sip_conf = "/etc/asterisk/sip_additional.conf";
contrib/scripts/retrieve_sip_conf_from_mysql.pl:$database = "sip";
contrib/scripts/retrieve_sip_conf_from_mysql.pl:open EXTEN, ">$sip_conf" || die "Cannot create/overwrite extensions file: $sip_conf\n";
contrib/scripts/retrieve_sip_conf_from_mysql.pl: print "No sip accounts defined in $table_name\n";
contrib/scripts/ast_logescalator: \$astlogdir/sip_history.\$UNIQUEID.
contrib/scripts/ast_logescalator: \$astlogdir/sip_history.\$uniqueid
contrib/scripts/ast_logescalator:[SIP,on]="sip set debug on" [SIP,off]="sip set debug off"
contrib/scripts/ast_logescalator: --sip-history=*)
contrib/scripts/ast_logescalator: asterisk -rx "sip set debug off"
contrib/scripts/ast_logescalator: asterisk -rx "sip set history off"
contrib/scripts/ast_logescalator: SIP_HISTORY_LOG="$LOG_DIR/sip_history.${UNIQUEID}"
contrib/scripts/ast_logescalator: [sip_debug](!)
contrib/scripts/ast_logescalator: sip set debug on = yes
contrib/scripts/ast_logescalator: [sip_history](!)
contrib/scripts/ast_logescalator: sip set history on = yes
contrib/scripts/ast_logescalator: SIP_HISTORY_LOG=$(sed -n -r -e "s at logger add channel ($LOG_DIR/sip_history\..+)\s+SIP.*@\1 at p" "$CLI_CONF")
There also seem to be a bunch of alembic scripts left. I'm not sure if those have to stay or not, maybe somebody else knows, but just wanted to point these out:
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: 'sippeers',
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: name='sip_transport_values')),
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: name='sip_dtmfmode_values')),
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: name='sip_directmedia_values')),
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: name='sip_progressinband_values')),
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: name='sip_session_timers_values')),
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: name='sip_session_refresher_values')),
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: name='sip_callingpres_values')),
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: op.create_index('sippeers_name', 'sippeers', ['name'])
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: op.create_index('sippeers_name_host', 'sippeers', ['name', 'host'])
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: op.create_index('sippeers_ipaddr_port', 'sippeers', ['ipaddr', 'port'])
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: op.create_index('sippeers_host_port', 'sippeers', ['host', 'port'])
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: op.drop_table('sippeers')
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: 'sip_transport_values','sip_dtmfmode_values','sip_directmedia_values',
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: 'sip_progressinband_values','sip_session_timers_values','sip_session_refresher_values',
contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py: 'sip_callingpres_values','iax_requirecalltoken_values','iax_encryption_values',
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:"""Add Outgoing enum value to sippeers directmedia
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:old_type = sa.Enum(*OLD_ENUM, name='sip_directmedia_values')
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:new_type = sa.Enum(*NEW_ENUM, name='sip_directmedia_values_v2')
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py:tcr = sa.sql.table('sippeers', sa.Column('directmedia', new_type,
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: op.alter_column('sippeers', 'directmedia',
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: name="sip_directmedia_values_v2")
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: op.execute('ALTER TABLE sippeers ALTER COLUMN directmedia TYPE'
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: ' sip_directmedia_values_v2 USING'
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: ' directmedia::text::sip_directmedia_values_v2')
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: ENUM(name="sip_directmedia_values").drop(op.get_bind(), checkfirst=False)
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: op.alter_column('sippeers', 'directmedia',
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: name="sip_directmedia_values")
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: op.execute('ALTER TABLE sippeers ALTER COLUMN directmedia TYPE'
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: ' sip_directmedia_values USING'
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: ' directmedia::text::sip_directmedia_values')
contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py: ENUM(name="sip_directmedia_values_v2").drop(op.get_bind(),
contrib/ast-db-manage/config/versions/339a3bdf53fc_expand_accountcode_to_80.py: with op.batch_alter_table('sippeers') as batch_op:
contrib/ast-db-manage/config/versions/339a3bdf53fc_expand_accountcode_to_80.py: with op.batch_alter_table('sippeers') as batch_op:
contrib/ast-db-manage/config/versions/1758e8bbf6b_increase_useragent_column_size.py: op.alter_column('sippeers', 'useragent', type_=sa.String(255))
contrib/ast-db-manage/config/versions/1758e8bbf6b_increase_useragent_column_size.py: op.alter_column('sippeers', 'useragent', type_=sa.String(20))
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19611
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic700168c80b68879d9cee8bb07afe2712fb17996
Gerrit-Change-Number: 19611
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 14:15:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/cb05353a/attachment-0001.html>
More information about the asterisk-code-review
mailing list