[Asterisk-code-review] app_signal: Add signaling applications (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Mark Murawski.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17786 )

Change subject: app_signal: Add signaling applications
......................................................................


Patch Set 6:

(1 comment)

File apps/app_signal.c:

https://gerrit.asterisk.org/c/asterisk/+/17786/comment/d4005b68_0e0ee463 
PS4, Line 278: 		remove_signal(signame);
> This doesn't resolve the issue. The get_signal function can still get the signal before this point. […]
Ah, I see. Okay, I've moved the WRLOCK to before watchers itself gets decremented. It will then only get destroyed if that hits 0, and get_signal also grabs a WRLOCK, so this should be perfectly atomic now. We don't release the WRLOCK until after the destroy, so nobody else even needs to check the watch count.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17786
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3
Gerrit-Change-Number: 17786
Gerrit-PatchSet: 6
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Thu, 22 Dec 2022 13:27:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/b89929e0/attachment.html>