[Asterisk-code-review] app_signal: Add signaling applications (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A, Mark Murawski.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/17786 )

Change subject: app_signal: Add signaling applications
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

File apps/app_signal.c:

https://gerrit.asterisk.org/c/asterisk/+/17786/comment/80a016b1_8baf62f2 
PS4, Line 278: 		remove_signal(signame);
> I think this could be fixed by simply calling remove_signal before ast_mutex_unlock, i.e. […]
This doesn't resolve the issue. The get_signal function can still get the signal before this point. Locking signals doesn't guarantee that it doesn't happen. As for destroying a locked mutex, you can't.

What you're running into is reference counting issues. AO2 exists to handle this situation, and ensure that things are destroyed when the last reference is given up, and that acquiring an object from a container raises that reference count.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/17786
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3
Gerrit-Change-Number: 17786
Gerrit-PatchSet: 5
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Mark Murawski <markm at intellasoft.net>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Mark Murawski <markm at intellasoft.net>
Gerrit-Comment-Date: Thu, 22 Dec 2022 12:57:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/2147247d/attachment.html>