[Asterisk-code-review] config.c: Make ast_variable_retrieve return last match. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Thu Dec 22 04:33:47 CST 2022


Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19744 )

Change subject: config.c: Make ast_variable_retrieve return last match.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Patchset:

PS1: 
>From what I can tell this behavior has existed since the dawn of this function, which was something like 17 years ago. This needs an UPGRADE note at the very least. Input from others would also be good. My fear is that by fixing this, we will end up breaking configs or changing things for existing users without them actually noticing.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19744
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia681407275a557c1462f93832a4d45f31c580354
Gerrit-Change-Number: 19744
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Thu, 22 Dec 2022 10:33:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/9b6248fb/attachment.html>


More information about the asterisk-code-review mailing list