[Asterisk-code-review] res_http_media_cache: Introduce options and customize (asterisk[20])

[Joshua Colp]

Attention is currently required from: Sean Bright, Holger Hans Peter Freyther.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Introduce options and customize
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/2e4ff5ff_7f0a9dcf 
PS5, Line 734: #ifdef AST_CURL_HAS_PROTOCOLS_STR
Configuration options shouldn't be ifdeffed out like this. It causes confusion for users, and for developers. If the option is used on a system that doesn't have it, the configuration will fail saying the option doesn't exist which doesn't give feedback to the user about what has actually happened.

In these cases a pre_apply_config callback should be added to CONFIG_INFO_STANDARD. This callback can then examine "protocols" and "redirect_protocols". If these are set, but the functionality is not present, then an ERROR message can be output telling the user that their version of curl doesn't support it and to remove the options, or to upgrade curl to support it. Returning -1 from the callback will cause the configuration to not be loaded.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 5
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Comment-Date: Thu, 22 Dec 2022 10:07:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/561e4a47/attachment-0001.html>