[Asterisk-code-review] res_pjsip: mediasec: Add Security-Client headers after 401 (asterisk[18])

Joshua Colp asteriskteam at digium.com
Thu Dec 22 04:01:05 CST 2022


Attention is currently required from: Maximilian Fridrich.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19740 )

Change subject: res_pjsip: mediasec: Add Security-Client headers after 401
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File res/res_pjsip_rfc3329.c:

https://gerrit.asterisk.org/c/asterisk/+/19740/comment/5a116d88_b1d78fb8 
PS2, Line 37: static pjsip_module rfc3329_module = {
Is there no other way to accomplish this? There is a fixed number of pjsip_modules that can exist in PJSIP, so avoiding their use for things like this is best practice.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19740
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ief7857365f221b1ef28672a27cc3fb27384c8d0f
Gerrit-Change-Number: 19740
Gerrit-PatchSet: 2
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 10:01:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/06aefe2a/attachment-0001.html>


More information about the asterisk-code-review mailing list