[Asterisk-code-review] apps/app_queue: Preserve reason for realtime queues (asterisk[18])

Niklas Larsson asteriskteam at digium.com
Thu Dec 22 03:07:21 CST 2022


Attention is currently required from: N A, Alexei Gradinari, Stanislav Abramenkov.

Niklas Larsson has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19741 )

Change subject: apps/app_queue: Preserve reason for realtime queues
......................................................................


Patch Set 5:

(2 comments)

Patchset:

PS4: 
> Need doc/CHANGES-staging/
Done


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/58bc41c7_4b5cb5a1 
PS4, Line 7754: update_realtime_member_field
> Ok found out that you can send multiple field, value to ast_update_realtime.  […]
ast_realtime_require_field (in 18 and res_config_mysql) - does not return -1 for "Table %s requires a column ...". Used ast_variable_retrieve instead as a workaround.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 5
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 09:07:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Comment-In-Reply-To: Niklas Larsson <niklas at tese.se>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221222/09da5c1c/attachment.html>


More information about the asterisk-code-review mailing list