[Asterisk-code-review] apps/app_queue: Preserve reason for realtime queues (asterisk[18])

[N A]

Attention is currently required from: Stanislav Abramenkov, Niklas Larsson.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19741 )

Change subject: apps/app_queue: Preserve reason for realtime queues
......................................................................


Patch Set 3: Code-Review-1

(5 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/a31122c8_a4e45b93 
PS3, Line 9: When the Asterisk is restared it does not preserve paused reason for
restarted


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/dfe6ff50_6159f597 
PS3, Line 11: https://gerrit.asterisk.org/c/asterisk/+/2131/
Reference the issue number like so: ASTERISK_25732


File apps/app_queue.c:

https://gerrit.asterisk.org/c/asterisk/+/19741/comment/407cab09_f1424da8 
PS3, Line 3657: 			ast_copy_string(m->reason_paused, (reason_paused ? reason_paused : "\0"), sizeof(m->reason_paused));
Use S_OR(reason_paused, "")


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/d228fc57_75de3ec7 
PS3, Line 3672: 			if (!ast_strlen_zero(reason_paused)){
Missing space between ) and {


https://gerrit.asterisk.org/c/asterisk/+/19741/comment/a158d705_2842c2ab 
PS3, Line 7753: 		if (strcmp(mem->reason_paused, reason ? reason : "\0")){
Same here, use S_OR



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19741
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: Ica08baa5cab6b18105b5d719a183f9fd582fcf09
Gerrit-Change-Number: 19741
Gerrit-PatchSet: 3
Gerrit-Owner: Niklas Larsson <niklas at tese.se>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Stanislav Abramenkov <stas.abramenkov at gmail.com>
Gerrit-Attention: Niklas Larsson <niklas at tese.se>
Gerrit-Comment-Date: Wed, 21 Dec 2022 14:02:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221221/1ff0f73b/attachment.html>