[Asterisk-code-review] res_pjsip_rfc3326: Add SIP causes support for RFC3326 (asterisk[18])

N A asteriskteam at digium.com
Mon Dec 19 08:43:05 CST 2022


Attention is currently required from: Joshua Colp, Igor Goncharovsky.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19570 )

Change subject: res_pjsip_rfc3326: Add SIP causes support for RFC3326
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

File res/res_pjsip_rfc3326.c:

https://gerrit.asterisk.org/c/asterisk/+/19570/comment/6c1d376b_ebf5034b 
PS6, Line 57: 			if ((text = strstr(cause, ";"))) {
You can use strchr here since ; is a single character, rather than strstr



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19570
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I3f55622dc680ce713a2ffb5a458ef5dd39fcf645
Gerrit-Change-Number: 19570
Gerrit-PatchSet: 6
Gerrit-Owner: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Igor Goncharovsky <igor.goncharovsky at gmail.com>
Gerrit-Comment-Date: Mon, 19 Dec 2022 14:43:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221219/909b8e4d/attachment.html>


More information about the asterisk-code-review mailing list