[Asterisk-code-review] res_monitor: Remove deprecated module. (asterisk[master])

[N A]

Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19605 )

Change subject: res_monitor: Remove deprecated module.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: 
This is going to be an invalid documentation reference if not removed:

main/features_config.c:                                         to be monitored by the <literal>Monitor</literal> application. The

Also:
bridges/bridge_builtin_features.c:              var_monitor = "TOUCH_MIXMONITOR";
bridges/bridge_builtin_features.c:              var_monitor = "TOUCH_MONITOR";


TOUCH_MONITOR is for Monitor so don't think that's needed anymore?


configs/samples/queues.conf.sample:;    By setting monitor-type = MixMonitor, when specifying monitor-format
configs/samples/queues.conf.sample:; monitor-type = MixMonitor


This should be updated, since only MixMonitor is valid now. The UPGRADE file should also mention this.


These should be removed:
configs/samples/features.conf.sample:;pauseMonitor   => #1,self/callee,Pausemonitor     ;Allow the callee to pause monitoring
configs/samples/features.conf.sample:;unpauseMonitor => #3,self/callee,UnPauseMonitor   ;Allow the callee to unpause monitoring


Also, could the ast_channel_monitor/ast_channel_monitor_set APIs be deprecated or removed in the future? It seems like only MeetMe is using them now.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19605
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I0462caefb4f9544e2e2baa23c498858310b52d50
Gerrit-Change-Number: 19605
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 19:27:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221213/259db1a0/attachment.html>