[Asterisk-code-review] chan_sip: Remove deprecated module. (asterisk[master])

[N A]

Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19611 )

Change subject: chan_sip: Remove deprecated module.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Patchset:

PS2: 
A few more things that can be cleaned up, mainly sip.conf related stuff:

res/ari/resource_endpoints.h:   /*! Technology of the endpoints (sip,iax2,...) */
res/res_phoneprov.c:/*! \li \ref res_phoneprov.c uses the configuration file \ref phoneprov.conf and \ref users.conf and \ref sip.conf
res/res_phoneprov.c:#define SIPUSERS_PROVIDER_NAME "sipusers"
res/res_phoneprov.c:            if ((cfg = ast_config_load("sip.conf", config_flags)) && cfg != CONFIG_STATUS_FILEINVALID) {
res/res_phoneprov.c:    /* This cleans up the sip.conf/users.conf provider (called specifically for clarity) */
res/res_phoneprov.c:    /* Register ourselves as the provider for sip.conf/users.conf */

include/asterisk/config_options.h:      const char *matchvalue; /*!< The value of the option to require for matching (i.e. 'peer' for type= in sip.conf) */

main/config.c:          if (!strcasecmp(v->name, "sipfriends")) {
main/config.c:                  ast_log(LOG_WARNING, "The 'sipfriends' table is obsolete, update your config to use sippeers instead.\n");
main/config.c:                  ast_realtime_append_mapping("sippeers", driver, database, table ? table : "sipfriends", pri);

main/udptl.c:           ast_log(LOG_WARNING, "t38faxudpec in udptl.conf is no longer supported; use the t38pt_udptl configuration option in sip.conf instead.\n");

configs/samples/res_config_mysql.conf.sample:;    sippeers => mysql,readhost.asterisk/writehost.asterisk,sippeers


configs/samples/extensions.ael.sample:// Note that you must have a [sipprovider] section in sip.conf whereas
configs/samples/extensions.ael.sample://_41X. => Dial(SIP/${EXTEN:2}@sipprovider,,r);
configs/samples/cli_aliases.conf.sample:sip debug=sip set debug
configs/samples/cli_aliases.conf.sample:sip no debug=sip set debug off
configs/samples/cli_aliases.conf.sample:sip history=sip set history on
configs/samples/cli.conf.sample:;sip set debug on = yes
configs/samples/extconfig.conf.sample:;sippeers => odbc,asterisk
configs/samples/extconfig.conf.sample:;sipregs => odbc,asterisk ; (avoid sipregs if possible, e.g. by using a view)
configs/samples/res_config_mysql.conf.sample:;    sippeers => mysql,readhost.asterisk/writehost.asterisk,sippeers


configs/samples/users.conf.sample:; files (e.g. sip.conf, iax.conf, etc) but is intended to accelerate the
configs/samples/users.conf.sample:hassip = yes
configs/samples/users.conf.sample:;hassip = yes
configs/samples/sip_notify.conf.sample:Content=>Message-Account: sip:asterisk at 127.0.0.1
configs/samples/sip_notify.conf.sample:[sipura-check-cfg]
configs/samples/sip_notify.conf.sample:[sipura-get-report]


configs/samples/res_ldap.conf.sample:;  sip.conf = ldap,"dc=myDomain,dc=myDomainExt",config

configs/samples/extensions.lua.sample:          -- not have allowguest=no in sip.conf, everybody out there may use your


configs/samples/extensions.conf.sample:;exten => _41X.,1,Dial(SIP/${FILTER(0-9,${EXTEN:2})}@sipprovider,,r)


configs/samples/cli_permissions.conf.sample:;          sip show peer
configs/samples/cli_permissions.conf.sample:; allowing the user to use 'channel originate' on a sip channel and with the 'extension'
configs/samples/cli_permissions.conf.sample:; permit=sip show       ; all commands starting with 'sip show' will be allowed
configs/samples/cli_permissions.conf.sample:;permit=sip
configs/samples/cli_permissions.conf.sample:;permit=sip show peer
configs/samples/cli_permissions.conf.sample:;deny=sip show peers
configs/samples/cli_permissions.conf.sample:;   permit=sip show


pbx/pbx_config.c:               if (ast_true(ast_config_option(cfg, cat, "hassip"))) {


rest-api/api-docs/endpoints.json:                                                       "description": "Technology of the endpoints (sip,iax2,...)",



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19611
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ic700168c80b68879d9cee8bb07afe2712fb17996
Gerrit-Change-Number: 19611
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 19:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221213/8e7760f8/attachment.html>