[Asterisk-code-review] res_rtp_asterisk: Asterisk Media Experience Score (MES) (asterisk[18])

[George Joseph]

Attention is currently required from: Joshua Colp, Kevin Harwell.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19479 )

Change subject: res_rtp_asterisk: Asterisk Media Experience Score (MES)
......................................................................


Patch Set 5:

(4 comments)

File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/c/asterisk/+/19479/comment/c73b9865_af170e26 
PS4, Line 457: 					<enum name="rxmes"><para>Received packet jitter</para></enum>
> Received packet jitter?
Done


File doc/CHANGES-staging/res_rtp_asterisk.txt:

https://gerrit.asterisk.org/c/asterisk/+/19479/comment/8bef7a16_6ab2f78b 
PS4, Line 5: Media Experience Score.  The score is avilable using
> available
Done


File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/c/asterisk/+/19479/comment/12c2e29d_e9e4fbaf 
PS4, Line 201: #define RTP_IGNORE_FIRST_PACKETS_COUNT 15
> What prompted 15?

pjproject used 25 but based on packet flows I analyzed between phones and asterisk, 15 seemed reasonable.  Mostly the issue is just one starting before the other.
I'll update the comment.


https://gerrit.asterisk.org/c/asterisk/+/19479/comment/cf6df9a0_df7546e3 
PS4, Line 451: 	struct ast_rtp_instance *owner;   /*!< The RTP instance owning us (used for debugging purposes) */
> Clarify that this does not hold a reference, but will remain valid.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19479
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 18
Gerrit-Change-Id: I458cb9a311e8e5dc1db769b8babbcf2e093f107a
Gerrit-Change-Number: 19479
Gerrit-PatchSet: 5
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Kevin Harwell <default.enum at gmail.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Kevin Harwell <default.enum at gmail.com>
Gerrit-Comment-Date: Tue, 13 Dec 2022 13:39:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221213/92475fe0/attachment.html>