[Asterisk-code-review] app_if: Fix format truncation errors. (asterisk[master])

George Joseph asteriskteam at digium.com
Tue Dec 13 07:01:06 CST 2022


Attention is currently required from: N A.

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19706 )

Change subject: app_if: Fix format truncation errors.
......................................................................


Patch Set 1: Code-Review-2

(1 comment)

Patchset:

PS1: 
Doesn't fix the issue.  I still get...
```
app_if.c: In function ‘if_helper’:
app_if.c:274:63: error: ‘%s’ directive output may be truncated writing up to 66 bytes into a region of size 64 [-Werror=format-truncation=]
  274 |                 snprintf(end_varname,sizeof(end_varname),"END_%s",varname);
      |                                                               ^~  ~~~~~~~
app_if.c:274:17: note: ‘snprintf’ output between 5 and 71 bytes into a destination of size 68
  274 |                 snprintf(end_varname,sizeof(end_varname),"END_%s",varname);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
app_if.c:284:63: error: ‘%s’ directive output may be truncated writing up to 66 bytes into a region of size 64 [-Werror=format-truncation=]
  284 |                 snprintf(end_varname,sizeof(end_varname),"END_%s",varname);
      |                                                               ^~  ~~~~~~~
app_if.c:284:17: note: ‘snprintf’ output between 5 and 71 bytes into a destination of size 68
  284 |                 snprintf(end_varname,sizeof(end_varname),"END_%s",varname);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
app_if.c:284:63: error: ‘%s’ directive output may be truncated writing up to 66 bytes into a region of size 64 [-Werror=format-truncation=]
  284 |                 snprintf(end_varname,sizeof(end_varname),"END_%s",varname);
      |                                                               ^~  ~~~~~~~
app_if.c:284:17: note: ‘snprintf’ output between 5 and 71 bytes into a destination of size 68
  284 |                 snprintf(end_varname,sizeof(end_varname),"END_%s",varname);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
app_if.c:284:63: error: ‘%s’ directive output may be truncated writing up to 66 bytes into a region of size 64 [-Werror=format-truncation=]
  284 |                 snprintf(end_varname,sizeof(end_varname),"END_%s",varname);
      |                                                               ^~  ~~~~~~~
app_if.c:284:17: note: ‘snprintf’ output between 5 and 71 bytes into a destination of size 68
  284 |                 snprintf(end_varname,sizeof(end_varname),"END_%s",varname);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

```



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19706
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I42be4edf0284358b906e765d1966b6b9d66e1d3c
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 1
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Tue, 13 Dec 2022 13:01:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221213/b466bceb/attachment-0001.html>


More information about the asterisk-code-review mailing list