[Asterisk-code-review] app_macro: Remove deprecated module. (asterisk[master])

N A asteriskteam at digium.com
Mon Dec 12 13:26:24 CST 2022


Attention is currently required from: Michael Bradeen.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19708 )

Change subject: app_macro: Remove deprecated module.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Patchset:

PS1: 
> The sample configs also need updating to remove all references to macros. A few in particular: […]
I think you missed a few from the list above, and still some stuff leftover, try running the following:

grep -R "acro" | grep "samples"


File doc/UPGRADE-staging/app_macro_removal.txt:

https://gerrit.asterisk.org/c/asterisk/+/19708/comment/d6274f99_83ed32dd 
PS2, Line 7: 
This should also mention all the options to the various applications (e.g. Dial) that have been removed, removed config options e.g. different logging format for minivm, etc. Every application with options removed should be mentioned.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19708
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I830daab293117179b8d61bd4df0d971a1b3d07f6
Gerrit-Change-Number: 19708
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Mon, 12 Dec 2022 19:26:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221212/d2ed1396/attachment-0001.html>


More information about the asterisk-code-review mailing list