[Asterisk-code-review] res_http_media_cache: Allow to customize parameters (asterisk[20])

[Holger Hans Peter Freyther]

Attention is currently required from: N A.

Holger Hans Peter Freyther has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19658 )

Change subject: res_http_media_cache: Allow to customize parameters
......................................................................


Patch Set 2:

(8 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/450e1ca5_c9d90726 
PS1, Line 10: but don't make it mandatory yet.
> So it will be mandatory in the future?
I don't know the policy on breaking changes. I think from a safety point of view it would make sense (e.g. for putting that info into the wrong filename and it never been picked).


Patchset:

PS1: 
> This also needs a CHANGES entry
Done


File res/res_http_media_cache.c:

https://gerrit.asterisk.org/c/asterisk/+/19658/comment/97e0484b_9cad7e97 
PS1, Line 40: 				<configOption name="timeout_seconds">
> You should specify the default as well, e.g. name="timeout_secs" default="180".
Done


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/343b650e_46d213b5 
PS1, Line 52: 			</configObject>
> You submitted 3 other reviews for this config, why are they not all part of the same commit?
I am happy to squash them. I split them up to make it easier for review. This one to introduce a config file and the others to extend the options we want to configure.


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/3ae78b79_cf129ee5 
PS1, Line 70: static int cache_curl_timeout = 180;
> It would be nice if these were documented briefly (just a /*! \brief desc */ is fine)
Done


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/f74e438e_98c5cd67 
PS1, Line 360: 	curl_easy_setopt(curl, CURLOPT_USERAGENT, cache_curl_useragent != NULL ? cache_curl_useragent : AST_CURL_USER_AGENT);
> You could use the S_OR macro here
Done


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/e75b5f4d_fbf7ad30 
PS1, Line 578: 	if (cfg == CONFIG_STATUS_FILEMISSING) {
> There should be some log message here (perhaps NOTICE) that the file is missing, otherwise there won […]
Done. Now the caller reads if (load_config()) { return }


https://gerrit.asterisk.org/c/asterisk/+/19658/comment/0ae70bb7_464ea137 
PS1, Line 592: 		if (strcasecmp(cat, "general") == 0) {
> use !strcasecmp instead of == 0
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19658
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I2eb02ef44190e026716720419bcbdbcc8125777b
Gerrit-Change-Number: 19658
Gerrit-PatchSet: 2
Gerrit-Owner: Holger Hans Peter Freyther <automatic at freyther.de>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <asterisk at phreaknet.org>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Sat, 10 Dec 2022 12:20:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: N A <asterisk at phreaknet.org>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221210/d82b1dd2/attachment-0001.html>