[Asterisk-code-review] pbx_dundi: Add PJSIP support. (asterisk[master])

[Joshua Colp]

Attention is currently required from: N A.

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19702 )

Change subject: pbx_dundi: Add PJSIP support.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

File pbx/pbx_dundi.c:

https://gerrit.asterisk.org/c/asterisk/+/19702/comment/1eac3524_ece43249 
PS2, Line 4900: 			snprintf(req, sizeof(req), "%s/%s/%s@%s,,%s", results[x].tech, pjsip_outgoing_endpoint, S_OR(number, ""), ip, S_OR(dundiargs, ""));
This doesn't work. The format is:

PJSIP/endpoint/URI

You can't dial PJSIP/endpoint/1000 at ip, as 1000 at ip is not a valid URI.

sip:1000 at ip would be a valid URI.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19702
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I2e28e5a5d007bd49e3df113ad567b011103899bf
Gerrit-Change-Number: 19702
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: N A <asterisk at phreaknet.org>
Gerrit-Comment-Date: Fri, 09 Dec 2022 15:00:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221209/1c07349c/attachment.html>