[Asterisk-code-review] loader: Allow declined modules to be unloaded. (asterisk[master])

[N A]

Attention is currently required from: George Joseph.

N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19657 )

Change subject: loader: Allow declined modules to be unloaded.
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2: 
> If a module declines to load, what's the downside to closing/unloading it at that point?
That was the other thing I considered... it could probably be done either way.

I think the advantage of leaving it "loaded" (but not really loaded) is that it will show up in the list when you do "module show", i.e. the module is registered with Asterisk even if it isn't running. If you unload the module, then it disappears from the list entirely, which might confuse people.

At least, that's my guess as to why they never unloaded to begin with and just left it there.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19657
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ifc743aadfa85ebe3284e02a63e124dafa64988d5
Gerrit-Change-Number: 19657
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-CC: George Joseph <gjoseph at digium.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 09 Dec 2022 13:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221209/253440a7/attachment.html>