[Asterisk-code-review] sig_analog: Fix no timeout duration. (asterisk[20])

Friendly Automation asteriskteam at digium.com
Thu Dec 8 10:13:52 CST 2022


Friendly Automation has submitted this change. ( https://gerrit.asterisk.org/c/asterisk/+/19598 )

Change subject: sig_analog: Fix no timeout duration.
......................................................................

sig_analog: Fix no timeout duration.

ASTERISK_28702 previously attempted to fix an
issue with flash hook hold timing out after
just under 17 minutes, when it should have never
been timing out. It fixed this by changing 999999
to INT_MAX, but it did so in chan_dahdi, which
is the wrong place since ss_thread is now in
sig_analog and the one in chan_dahdi is mostly
dead code.

This fixes this by porting the fix to sig_analog.

ASTERISK-30336 #close

Change-Id: I05eb69cc0b5319d357842a70bd26ef64d145cb15
---
M channels/sig_analog.c
1 file changed, 23 insertions(+), 1 deletion(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit




diff --git a/channels/sig_analog.c b/channels/sig_analog.c
index ccc14a8..b694a96 100644
--- a/channels/sig_analog.c
+++ b/channels/sig_analog.c
@@ -2138,7 +2138,7 @@
 		/* If starting a threeway call, never timeout on the first digit so someone
 		   can use flash-hook as a "hold" feature */
 		if (p->subs[ANALOG_SUB_THREEWAY].owner) {
-			timeout = 999999;
+			timeout = INT_MAX;
 		}
 		while (len < AST_MAX_EXTENSION-1) {
 			int is_exten_parking = 0;

-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19598
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 20
Gerrit-Change-Id: I05eb69cc0b5319d357842a70bd26ef64d145cb15
Gerrit-Change-Number: 19598
Gerrit-PatchSet: 2
Gerrit-Owner: N A <asterisk at phreaknet.org>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: merged
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20221208/6ef3412d/attachment.html>


More information about the asterisk-code-review mailing list