[Asterisk-code-review] app_mixmonitor: Close stream if playing beep failed (asterisk[19.5])

[Julien Alie]

Attention is currently required from: Sean Bright, George Joseph.

Julien Alie has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/19040 )

Change subject: app_mixmonitor: Close stream if playing beep failed
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1: 
> There are dozens of places where we call ast_stream_and_wait() throughout the code and don't check i […]
You are right, a better fix would be to patch ast_stream_and_wait (or inner functions) directly.  I'll investigate side effects by applying fix in ast_stream_and_wait instead and possibly write some test code, I'll just need to acquaint myself with Asterisk's test framework first.


PS1: 
> Reviews should never be submitted against minor release branches.
I'll release reworked version against master since this bug is still present in current versions,

Thank you



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/19040
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 19.5
Gerrit-Change-Id: Ib3e4994766f825d5de943c81331ff3c5c23fb189
Gerrit-Change-Number: 19040
Gerrit-PatchSet: 1
Gerrit-Owner: Julien Alie <jalie at wazo.io>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: Sean Bright <sean at seanbright.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Wed, 31 Aug 2022 20:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean at seanbright.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220831/539b3c24/attachment.html>