[Asterisk-code-review] res_pjsip_sdp_rtp: Skip formats without SDP details. (asterisk[16])

[George Joseph]

Attention is currently required from: Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18991 )

Change subject: res_pjsip_sdp_rtp: Skip formats without SDP details.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

Patchset:

PS1: 
-1 only to ping about adding the warning.  Otherwise, tested fine with various codec combinations that previously resulted in no SDP being generated.


File res/res_pjsip_sdp_rtp.c:

https://gerrit.asterisk.org/c/asterisk/+/18991/comment/59bb433b_b702df97 
PS1, Line 1827: 			ao2_ref(format, -1);
> I'm torn on adding a warning message here about disallowing the format.

Yeah, I'd add the warning.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18991
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3e37569aa4ca341260e6ca5904dc2f75e46a1749
Gerrit-Change-Number: 18991
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 30 Aug 2022 13:59:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220830/75a5a993/attachment.html>