[Asterisk-code-review] testuite: Python3 support ASTERISK-26826 (testsuite[16])

[Michael Bradeen]

Attention is currently required from: Joshua Colp, George Joseph.
Michael Bradeen has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18962 )

Change subject: testuite: Python3 support ASTERISK-26826
......................................................................


Patch Set 9:

(3 comments)

File requirements.txt:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/7be9b1d8_3de71ce6 
PS8, Line 16: numpy==1.23.2
> The highest version supported by CentOS seems to be 1.19.5 […]
Done


File runInVenv.sh:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/bc217f7e_eed3e40a 
PS8, Line 3: 
> Add "set -e" to catch errors in the script.
Done


File setupVenv.sh:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/1574a74a_f03918fe 
PS8, Line 2: 
> Might want to add a "set -e" here so the script aborts if any of the commands fail. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Id22c8f7a89e2d00fca760970af63f3954c049bf3
Gerrit-Change-Number: 18962
Gerrit-PatchSet: 9
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 18:41:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220829/3b32dbcd/attachment.html>