[Asterisk-code-review] testuite: Python3 support ASTERISK-26826 (testsuite[16])

[George Joseph]

Attention is currently required from: Michael Bradeen, Joshua Colp.
George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18962 )

Change subject: testuite: Python3 support ASTERISK-26826
......................................................................


Patch Set 8: Code-Review-1

(3 comments)

File requirements.txt:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/eba24700_4b16bdbb 
PS8, Line 16: numpy==1.23.2
The highest version supported by CentOS seems to be 1.19.5

ERROR: Could not find a version that satisfies the requirement numpy==1.23.2 (from 
versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 
<snip>
1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0rc1, 1.19.0rc2, 1.19.0, 1.19.1, 
1.19.2, 1.19.3, 1.19.4, 1.19.5)
ERROR: No matching distribution found for numpy==1.23.2


File runInVenv.sh:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/090d7fb1_27bcd26a 
PS8, Line 3: 
Add "set -e" to catch errors in the script.


File setupVenv.sh:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/674da3cf_f7ab2413 
PS8, Line 2: 
Might want to add a "set -e" here so the script aborts if any of the commands fail.  I only knew about the numpy issue because i saw the error scroll by.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Id22c8f7a89e2d00fca760970af63f3954c049bf3
Gerrit-Change-Number: 18962
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 11:17:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220829/fe540a8b/attachment.html>