[Asterisk-code-review] res_pjsip_pubsub: Postpone destruction of old subscriptions on RLS up... (asterisk[16])

[Joshua Colp]

Attention is currently required from: N A, Alexei Gradinari.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18891 )

Change subject: res_pjsip_pubsub: Postpone destruction of old subscriptions on RLS update
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

File res/res_pjsip_exten_state.c:

https://gerrit.asterisk.org/c/asterisk/+/18891/comment/b9e0c6f8_8d387f7b 
PS3, Line 342: 	/* Terminated subscriptions are no longer associated with a valid tree, and sending
This is already done in notify_task, so it should be explained here why it is also done.


File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/c/asterisk/+/18891/comment/855e61f2_a40cc854 
PS3, Line 4087: 						/* Postpone destruction until all already queued tasks that may by using old subscriptions have completed */
may be



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18891
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I96582aad3a26515ca73a8460ee6756f56f6ba23b
Gerrit-Change-Number: 18891
Gerrit-PatchSet: 3
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Mon, 29 Aug 2022 10:55:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220829/eb543118/attachment.html>