[Asterisk-code-review] res_pjsip: return all codecs on a re-INVITE without SDP (asterisk[16])

[N A]

Attention is currently required from: Henning Westerholt.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18990 )

Change subject: res_pjsip: return all codecs on a re-INVITE without SDP
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/e44908b8_186da31c 
PS2, Line 8: 
Wrap commit message at 72 characters to avoid wrapping


File configs/samples/pjsip.conf.sample:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/629f87bd_42457d1e 
PS2, Line 1281:                     ; If we should return all codecs on empty re-INVITE.
I don't think "If we should" is necessary, and just starting with "Return" is clearer to me. Either that or "Whether to return..."


https://gerrit.asterisk.org/c/asterisk/+/18990/comment/028f6070_4e885667 
PS2, Line 1282:                     ; RFC 3261 specify it SHOULD be done like this.
specifies


File include/asterisk/res_pjsip.h:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/79c622ae_6f8ab018 
PS2, Line 3505:  * \since unreleased
I don't think \since unreleased is needed


File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/43867641_9b310c04 
PS2, Line 2078: 						specify this as a SHOULD requirement.
specifies


File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/18990/comment/492eadff_a5153633 
PS2, Line 5231: 	ast_trace(-1, "session_inv_on_create_offer\n");
Should the -1 be 1?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18990
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I69763708d5039d512f391e296ee8a4d43a1e2148
Gerrit-Change-Number: 18990
Gerrit-PatchSet: 2
Gerrit-Owner: Henning Westerholt <hw at gilawa.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Henning Westerholt <hw at gilawa.com>
Gerrit-Comment-Date: Fri, 26 Aug 2022 13:42:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220826/e842eb0c/attachment.html>