[Asterisk-code-review] res_pjsip: Add TEL URI support for basic calls. (asterisk[16])
Benjamin Keith Ford
asteriskteam at digium.com
Wed Aug 17 15:10:44 CDT 2022
Attention is currently required from: Michael Bradeen, Joshua Colp.
Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18892 )
Change subject: res_pjsip: Add TEL URI support for basic calls.
......................................................................
Patch Set 4:
(3 comments)
This change is ready for review.
Commit Message:
https://gerrit.asterisk.org/c/asterisk/+/18892/comment/02c80de3_df183eff
PS2, Line 11: headers will now allow TEL URIs as well.
> As well as request URI.
Done
https://gerrit.asterisk.org/c/asterisk/+/18892/comment/ed3ad54c_a261757d
PS2, Line 13: Support is only for incoming calls.
> Support is only for tel URIs being present in traffic from a remote party. […]
Done
File res/res_pjsip/pjsip_message_filter.c:
https://gerrit.asterisk.org/c/asterisk/+/18892/comment/9dbdfccc_139ae9c0
PS2, Line 467: struct pjsip_request_line req = rdata->msg_info.msg->line.req;
> PJSIP has a native function for this[1]. […]
Done
--
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: If5729e6cd583be7acf666373bf9f1b9d653ec29a
Gerrit-Change-Number: 18892
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-CC: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 20:10:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220817/a877df70/attachment.html>
More information about the asterisk-code-review
mailing list