[Asterisk-code-review] res_pjsip_logger: Add method-based logging option. (asterisk[master])

[Alexei Gradinari]

Attention is currently required from: N A, Joshua Colp.
Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18824 )

Change subject: res_pjsip_logger: Add method-based logging option.
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
I still have objections.

1. I think it would be better to have AND condition for different filters: hosts and methods.
If I set both filters on hosts and methods I suppose that both filters are in effect. In your case I have to guess which one is in effect.

2. The command "method" set filter on one or more methods in your code.
To be consistent with host filter and the name of command (singular) it should set filter only on one method. In this case you should compare the whole string instead of substring.

3. The name and brief comment of function pjsip_log_test_addr don't reflect what this function does now.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idd03bd9b466b40e4bca7769437d52ac13a957cf9
Gerrit-Change-Number: 18824
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 14:18:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220817/f918ecfb/attachment.html>