[Asterisk-code-review] res_pjsip_logger: Add method-based logging option. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp, Alexei Gradinari.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18824 )

Change subject: res_pjsip_logger: Add method-based logging option.
......................................................................


Patch Set 3:

(3 comments)

File doc/CHANGES-staging/res_pjsip_logger_method.txt:

https://gerrit.asterisk.org/c/asterisk/+/18824/comment/2c8647e3_b67d6fce 
PS2, Line 3: SIP messages can now be filtered by SIP method,
> Same comment as in the code itself, this isn't clear enough about what filtering by SIP method actua […]
Done


File res/res_pjsip_logger.c:

https://gerrit.asterisk.org/c/asterisk/+/18824/comment/7ec9fff5_2f9b69b4 
PS2, Line 340: 	if (!pjsip_log_test_addr(default_logger, tdata->tp_info.dst_name, tdata->tp_info.dst_port, &tdata->msg->line.req.method)) {
> Host checking is being done outside of the actual SIP message itself. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/18824/comment/9c3a352c_38292831 
PS2, Line 340: 	if (!pjsip_log_test_addr(default_logger, tdata->tp_info.dst_name, tdata->tp_info.dst_port, &tdata->msg->line.req.method)) {
> Host checking is being done outside of the actual SIP message itself. […]
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18824
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Idd03bd9b466b40e4bca7769437d52ac13a957cf9
Gerrit-Change-Number: 18824
Gerrit-PatchSet: 3
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 11:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Comment-In-Reply-To: N A <mail at interlinked.x10host.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220817/06a52ff9/attachment.html>