[Asterisk-code-review] app_amd: Add option to play audio during AMD. (asterisk[master])

[N A]

Attention is currently required from: Joshua Colp.
N A has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18974 )

Change subject: app_amd: Add option to play audio during AMD.
......................................................................


Patch Set 2:

(3 comments)

File apps/app_amd.c:

https://gerrit.asterisk.org/c/asterisk/+/18974/comment/038e96b7_98a1a0a2 
PS1, Line 96: 				<para>Is an audio file to play to the caller while AMD is in progress.</para>
> Document the behavior if it is both configured in the configuration file, as well as here.
Done


https://gerrit.asterisk.org/c/asterisk/+/18974/comment/09733fe2_a430d1fd 
PS1, Line 201: 	const char *audioFile    = dfltAudioFile;
> This is unsafe. A reload could have freed it by the time it is used. […]
Done


File doc/CHANGES-staging/app_amd.txt:

https://gerrit.asterisk.org/c/asterisk/+/18974/comment/819ace99_9a5ab5a0 
PS1, Line 4: now be specified.
> can now be specified to the AMD application or configured in the configuration file.
Done



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18974
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4af306274552b61b3d9f0883c33f698abd4699b6
Gerrit-Change-Number: 18974
Gerrit-PatchSet: 2
Gerrit-Owner: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Wed, 17 Aug 2022 11:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220817/d522a36c/attachment-0001.html>