[Asterisk-code-review] testuite: Python3 support (testsuite[16])

[Joshua Colp]

Attention is currently required from: Michael Bradeen.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/18962 )

Change subject: testuite: Python3 support
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

Patchset:

PS3: 
Minor comments


File contrib/scripts/rlmi_demo.py:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/473c1739_7dde44e8 
PS3, Line 2: """Demonstration of parsing and print(ing RLMI XML document.
printing?


File lib/python/asterisk/asterisk.py:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/e1cb4ac3_ee408d57 
PS3, Line 468:             reactor.callLater(2, __execute_wait_fully_booted)
I'd add a comment here regarding 2


File lib/python/asterisk/sipp.py:

https://gerrit.asterisk.org/c/testsuite/+/18962/comment/8242ee86_5dfa059f 
PS3, Line 301:         reactor.callLater(1, self.do_start_callback)
What's the purpose of the start callback here? Should it be documented its behavior that it doesn't wait on SIPp?



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/18962
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Id22c8f7a89e2d00fca760970af63f3954c049bf3
Gerrit-Change-Number: 18962
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Michael Bradeen <mbradeen at sangoma.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 11:46:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/74be157d/attachment-0001.html>