[Asterisk-code-review] manager: be more aggressive about purging http sessions. (asterisk[master])

[Joshua Colp]

Attention is currently required from: Jaco Kroon.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18976 )

Change subject: manager: be more aggressive about purging http sessions.
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

File include/asterisk/tcptls.h:

https://gerrit.asterisk.org/c/asterisk/+/18976/comment/178c36be_c1e68a6d 
PS2, Line 141: 	void (*periodic_fn)(struct ast_tcptls_session_args *);/*!< something we may want to run before after select on the accept socket */
Why this change to the API? Everything else uses void * and then casts it in the callback.


File main/manager.c:

https://gerrit.asterisk.org/c/asterisk/+/18976/comment/0d87c00f_b2a92742 
PS2, Line 8643: 	if (purge_sessions(1) == 1) {
Document why it's behaving this way



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18976
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I4117ae25acc9c92bd1d3cfa73d7d334f5c3480c2
Gerrit-Change-Number: 18976
Gerrit-PatchSet: 2
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Attention: Jaco Kroon <jaco at uls.co.za>
Gerrit-Comment-Date: Tue, 16 Aug 2022 10:52:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/a1e7784d/attachment-0001.html>