[Asterisk-code-review] res_pjsip: Add 100rel option "peer_supported". (asterisk[16])

Joshua Colp asteriskteam at digium.com
Tue Aug 16 05:50:54 CDT 2022


Attention is currently required from: N A, Maximilian Fridrich.
Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/18838 )

Change subject: res_pjsip: Add 100rel option "peer_supported".
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

File res/res_pjsip/pjsip_config.xml:

https://gerrit.asterisk.org/c/asterisk/+/18838/comment/280e33ef_e4cf1584 
PS4, Line 44: 							<para>If set to <literal>peer_supported</literal>, send provisional responses
Let's document how exactly support is determined like "yes" is. I could see a user enabling this, it not working, and them being confused because they think the other side supports it but can't diagnose it further.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/18838
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id6d95ffa8f00dab118e0b386146e99f254f287ad
Gerrit-Change-Number: 18838
Gerrit-PatchSet: 4
Gerrit-Owner: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at sangoma.com>
Gerrit-Reviewer: N A <mail at interlinked.x10host.com>
Gerrit-Reviewer: Sean Bright <sean at seanbright.com>
Gerrit-Attention: N A <mail at interlinked.x10host.com>
Gerrit-Attention: Maximilian Fridrich <m.fridrich at commend.com>
Gerrit-Comment-Date: Tue, 16 Aug 2022 10:50:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20220816/c86433f7/attachment.html>


More information about the asterisk-code-review mailing list